Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move code to match nucleus and cytosol ids to own filtering class #2

Merged
merged 20 commits into from
Jun 5, 2024

Conversation

sophiamaedler
Copy link
Collaborator

code to match nucleus and cytosol ids to one another is currently implemented in multiple locations:

  1. within the segmentation workflows (https://github.com/MannLabs/SPARCSspatial/blob/main/src/sparcscore/pipeline/workflows.py#L707)
  2. within segmentation filtering workflows (https://github.com/MannLabs/SPARCSspatial/blob/main/src/sparcscore/pipeline/filtering_workflows.py#L25)

This makes the code difficult to maintain. Aim is to implement a new filtering class which provides the code implementation for the workflow which can be called in both of the named locations above.

@sophiamaedler sophiamaedler merged commit 7605640 into main Jun 5, 2024
2 checks passed
@sophiamaedler sophiamaedler deleted the code-refator_filtering branch June 5, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant